This repository has been archived by the owner on Apr 22, 2019. It is now read-only.
Save in gist #138
Open
Save in gist #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sweet! |
* redux: (35 commits) fixed setState warning (#151) Only save spec on parse Copy schema from docs instead of re-building vega. Update examples and images fixed router Add debounce Don’t format carefully crafted specs. cc @kanitw Open idl homepage in new window Enable escape on modal, larger modal Update CSS for DOM bindings. Fixes #144 Fix all the editor resize issues, make it much faster because we don’t redraw the editor any more, and also fix #145 Clean up header Fix warning about history push Show overflow so that tooltips work Clean up css Large modal Remove debugger that doesn’t work Clean up deployment Delete lockfile Fix prop warning ...
domoritz
reviewed
Jun 15, 2017
| @@ -0,0 +1,28 @@ | |||
| module['exports'] = function myService (hook) { | |||
|
|
|||
| var github = require('octonode'); | |||
|
|
||
| var github = require('octonode'); | ||
|
|
||
| var filename = hook.params.filename; |
There was a problem hiding this comment.
inline vars that are only used once
|
|
||
| var ghgist = client.gist(); | ||
|
|
||
| ghgist.create({ |
| const getSpecFromGistURL = (gistUrl, mode, cb) => { | ||
| let prefix = 'https://hook.io/tianyiii/vegaeditor/'; | ||
| let hookUrl = prefix + mode + '/' | ||
| + gistUrl.substring(gistUrl.indexOf('.com/') + '.com/'.length); |
There was a problem hiding this comment.
What is this doing? Could we use a regex instead? May be more readable.
| } | ||
| let username = arrayNames[1]; | ||
| let id = arrayNames[2]; | ||
| hashHistory.push('/gist/' + mode +'/' + username + '/' + id); |
| 50% { opacity:0; } | ||
| 100% { opacity:1; } | ||
| } | ||
| @-o-keyframes flickerAnimation{ |
There was a problem hiding this comment.
do we need the prefixing or does some plugin take care of it?
| }).then((value) => { | ||
| let arrayNames = value[filename].raw_url.split('/'); | ||
| let id = arrayNames[4]; | ||
| hashHistory.push('/gist/' + this.props.mode +'/anonymous/' + id); |
| const saveGist = ( | ||
| <div> | ||
| <div className='save-gist-content'> | ||
| Saving gist... please wait... |
There was a problem hiding this comment.
"Saving spec in gist. Please wait..."
| @@ -269,6 +278,25 @@ export default class Header extends React.Component { | |||
| </Portal> | |||
|
|
|||
| <Portal | |||
| closeOnOutsideClick={true} | |||
There was a problem hiding this comment.
The outside click doesn't work. Just remove it.
|
@mathisonian @tianyiii, should we try to get this in or wait and resolve conflicts later? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create save button that save spec as anonymous gist